Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XPK blueprint updates to make it more compatible with the tool #3192

Merged
merged 3 commits into from
Nov 25, 2024
Merged

XPK blueprint updates to make it more compatible with the tool #3192

merged 3 commits into from
Nov 25, 2024

Conversation

ankitkinra
Copy link
Contributor

@ankitkinra ankitkinra commented Oct 30, 2024 •
edited
Loading

Minor fixes for xpk compatibility

  • Update the naming convention of the node pools
  • Name the config map with deployment name

@ankitkinra ankitkinra marked this pull request as draft October 30, 2024 19:57
@ankitkinra
Update xpk blueprint after customer feedback≈
ac91be9 
Update configmap name so XPK provisioned jobs can find it
@ankitkinra
Add non gpu system pool
eac9aa2
@ankitkinra ankitkinra marked this pull request as ready for review November 8, 2024 21:55
@ankitkinra ankitkinra requested a review from sharabiani November 8, 2024 21:55
@ankitkinra ankitkinra added release-bugfix Added to release notes under the "Bug fixes" heading. release-improvements Added to release notes under the "Improvements" heading. and removed release-bugfix Added to release notes under the "Bug fixes" heading. labels Nov 8, 2024
@pawloch00
Copy link
Contributor

Should TAS be left here? @ankitkinra

annuay-google
annuay-google approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@annuay-google annuay-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, comment is non blocking

@ankitkinra
Copy link
Contributor Author

Should TAS be left here? @ankitkinra

We can potentially update in a follow up PR

@ankitkinra ankitkinra merged commit 0f8282c into GoogleCloudPlatform:develop Nov 25, 2024
12 of 61 checks passed
@ighosh98 ighosh98 mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawloch00 pawloch00 pawloch00 left review comments

@annuay-google annuay-google annuay-google approved these changes

@sharabiani sharabiani Awaiting requested review from sharabiani

Assignees
No one assigned
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankitkinra @pawloch00 @annuay-google