Update workload-identity submodule from v29 to v34 #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachaelSTamakloe
added
the
release-version-updates
tpdownes
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Very minor changes requested. It appears to me that our integration tests have succeeded, but I do not believe that the scope of those tests includes proper validation of GPU functionality. Please confirm with the GKE team whether this is the case. If it is, then manually test GPU functionality with nvidia-smi or similar job.
tpdownes
reviewed
Oct 31, 2024
tpdownes
reviewed
Oct 31, 2024
RachaelSTamakloe
force-pushed
the
update_gke_examples
branch
from
80e3175 to
716a78b
Compare
|
@RachaelSTamakloe I don't believe these changes require TPG 6.x. if you agree please modify the PR title from "use 6.x" to "be compatible with 6.x" (or similar wording conveying meaning) |
RachaelSTamakloe
changed the title
RachaelSTamakloe
force-pushed
the
update_gke_examples
branch
from
716a78b to
7cc8c41
Compare
RachaelSTamakloe
changed the title
tpdownes
approved these changes
Oct 31, 2024
RachaelSTamakloe
changed the title
RachaelSTamakloe
merged commit 850e365
into
GoogleCloudPlatform:develop
18 of 59 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.