Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_pods_per_node for GKE cluster and nodepool #3197

Merged
merged 15 commits into from
Nov 19, 2024
Merged

Add max_pods_per_node for GKE cluster and nodepool #3197

merged 15 commits into from
Nov 19, 2024

Conversation

pawloch00
Copy link
Contributor

@pawloch00 pawloch00 commented Oct 31, 2024 •
edited
Loading

Submission Checklist

Aim of this PR is to allow specifying max_pods_per node in GKE cluster and node pool. The change is introduced so user can specify number of pods per node and meet network requirements in specific cases.

Manual tests:

  • specify default_max_pods_per_node and max_pods_per_node in cluster and check if it is applied
  • specify default_max_pods_per_node and networking_mode to ROUTES and check if precondition fails

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@pawloch00
add max_pods_per_node
74bdf57 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
newlines
3e93304 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
update readme descriptions
28f4d11 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00 pawloch00 marked this pull request as ready for review November 4, 2024 08:58
@pawloch00 pawloch00 changed the base branch from main to develop November 4, 2024 11:42
@cdunbar13 cdunbar13 requested a review from ankitkinra November 4, 2024 16:57
@pawloch00 pawloch00 marked this pull request as draft November 4, 2024 21:22
@pawloch00 pawloch00 added the enhancement New feature or request label Nov 4, 2024
@pawloch00
terraform docs
9a6f1c4 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00 pawloch00 requested a review from sharabiani November 5, 2024 06:54
@pawloch00 pawloch00 marked this pull request as ready for review November 5, 2024 06:57
@pawloch00 pawloch00 added the release-improvements Added to release notes under the "Improvements" heading. label Nov 5, 2024
ankitkinra
ankitkinra reviewed Nov 5, 2024
View reviewed changes
modules/compute/gke-node-pool/README.md Outdated Show resolved Hide resolved
modules/scheduler/gke-cluster/main.tf Outdated Show resolved Hide resolved
sharabiani
sharabiani reviewed Nov 5, 2024
View reviewed changes
modules/scheduler/gke-cluster/variables.tf Outdated Show resolved Hide resolved
modules/scheduler/gke-cluster/main.tf Outdated Show resolved Hide resolved
@pawloch00
check networking_mode
697c359 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
check if not null
c2ed50b 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
use networking_mode in cluster only
57a133b 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
add precondition
78ebe74 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
set networking_mode default value to VPC_NATIVE
d8a833e 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
add precondition and data for node pool
e8b0ef4 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
set networking mode in gke_cluster
f3a07b5 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
sharabiani
sharabiani reviewed Nov 8, 2024
View reviewed changes
modules/compute/gke-node-pool/main.tf Outdated Show resolved Hide resolved
modules/scheduler/gke-cluster/variables.tf Outdated Show resolved Hide resolved
@pawloch00
review fixes
15f4d8f 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00 pawloch00 requested a review from sharabiani November 8, 2024 11:42
@pawloch00
review fixes
53cdf1c 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
fix index
b265725 
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00 pawloch00 merged commit 7644db7 into GoogleCloudPlatform:develop Nov 19, 2024
8 of 56 checks passed
@pawloch00 pawloch00 deleted the ppawl-max-pods-per-node branch November 19, 2024 13:17
@ighosh98 ighosh98 mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annuay-google annuay-google annuay-google approved these changes

@sharabiani sharabiani sharabiani approved these changes

@ankitkinra ankitkinra Awaiting requested review from ankitkinra

Assignees

@ankitkinra ankitkinra

@annuay-google annuay-google

Labels
enhancement New feature or request release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pawloch00 @ankitkinra @sharabiani @annuay-google