Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the gpu_installation_config default for case where no customer input #3259

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix the gpu_installation_config default for case where no customer input #3259

merged 2 commits into from
Nov 14, 2024

Conversation

ankitkinra
Copy link
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ankitkinra ankitkinra added the release-bugfix Added to release notes under the "Bug fixes" heading. label Nov 14, 2024
@ankitkinra ankitkinra merged commit f62f2bc into GoogleCloudPlatform:develop Nov 14, 2024
14 of 56 checks passed
@rohitramu rohitramu mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@annuay-google annuay-google

Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankitkinra @tpdownes @annuay-google