remove GKE reservation validation for local ssd NVMe/CSCI interface #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengcongdu
added
the
release-bugfix
ankitkinra
approved these changes
Nov 19, 2024
chengcongdu
merged commit 7c0939b
into
GoogleCloudPlatform:develop
8 of 56 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toolkit reservation validation on disk interface assume local_ssd_count_ephemeral_storage -> ephemeral_storage_local_ssd_config is using SCSI interface, which is not true according to the Terraform reference
This would break the use case of A3* Reservation (use NVMe by default for its local ssd).
Synced with @ankitkinra and agree on removing this reservation for now to unblock critical use case.
We need to better understand if this validation is still needed, or how we should update it.