Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Cluster Toolkit Dockerfile README #3290

Merged

Conversation

RachaelSTamakloe
Copy link
Collaborator

This PR updates the Cluster Toolkit Dockerfile README to include a note about configuring the necessary Google Cloud APIs, permissions, and credentials needed by the gcluster binary.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe added the release-improvements Added to release notes under the "Improvements" heading. label Nov 19, 2024
@RachaelSTamakloe RachaelSTamakloe merged commit f40317a into GoogleCloudPlatform:develop Nov 19, 2024
8 of 56 checks passed
@ighosh98 ighosh98 mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants