Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expanding subnetwork_cidr_suffix #3304

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ighosh98
Copy link
Contributor

@ighosh98 ighosh98 commented Nov 25, 2024

Submission Checklist

Increasing subnetwork_cidr_suffix to avoid IP_SPACE_EXHAUSTED errors. Integration tests passed successfully.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ighosh98 ighosh98 added the release-improvements Added to release notes under the "Improvements" heading. label Nov 25, 2024
Copy link
Contributor

@annuay-google annuay-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ankitkinra ankitkinra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment to blueprint explaining how many pods can this support ?

@ighosh98
Copy link
Contributor Author

Can you add a comment to blueprint explaining how many pods can this support ?

should it be nodes? something like: the subnet can hold 2^(32-20) = 4096 nodes

@ankitkinra
Copy link
Contributor

Can you add a comment to blueprint explaining how many pods can this support ?

should it be nodes? something like: the subnet can hold 2^(32-20) = 4096 nodes
Yes let's add it can support 4k nodes (we can skip the exact number)

@ighosh98 ighosh98 merged commit 8d3ed6c into GoogleCloudPlatform:develop Nov 26, 2024
8 of 57 checks passed
@ighosh98 ighosh98 deleted the develop-subnetwork branch November 26, 2024 01:48
@ighosh98 ighosh98 mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants