Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate tas plugin bug fixes #3339

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ighosh98
Copy link
Contributor

@ighosh98 ighosh98 commented Dec 4, 2024

Submission Checklist

Ran the command
kubectl create configmap topology-scheduler-scripts --namespace kube-system --from-file=label-nodes-daemon.py=label-nodes-daemon.py --from-file=schedule-daemon.py=schedule-daemon.py -o yaml --dry-run=client > topology-scheduler-scripts.yaml to generate the updated tas plugin script.

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ighosh98 ighosh98 added the release-improvements Added to release notes under the "Improvements" heading. label Dec 4, 2024
Copy link
Contributor

@annuay-google annuay-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please verify all file changes are as Dmitry sent

@ighosh98 ighosh98 merged commit c14e964 into GoogleCloudPlatform:develop Dec 4, 2024
8 of 58 checks passed
@nick-stroud nick-stroud mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants