Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating kueue v0.10.0 to enable TAS with rank ordering support #3417

Merged

Conversation

ighosh98
Copy link
Contributor

@ighosh98 ighosh98 commented Dec 17, 2024

Kueue v0.10.0 is the recommended solution for TAS with rank ordering support. We have ran internal validations and have approval on the stability of the version from Kueue team. This PR would enable cluster-toolkit customers to use the latest version out of the box by making a simple configuration change.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ighosh98 ighosh98 requested a review from ankitkinra December 17, 2024 10:30
@ighosh98 ighosh98 added the release-key-new-features Added to release notes under the "Key New Features" heading. label Dec 17, 2024
Copy link
Contributor

@ankitkinra ankitkinra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please point to kueue team's release notes on the version and also what new features, we are going to use ?

Also should we use this version in our a3u blueprints (with some default config) ?

@ighosh98
Copy link
Contributor Author

Can you please point to kueue team's release notes on the version and also what new features, we are going to use ?

Also should we use this version in our a3u blueprints (with some default config) ?

Yes. We should use it in a3 ultra. I was planning to make a PR on the private preview branch once this gets merged. Updated the release notes link in issue description. This contains bug fixes for TAS with Rank Ordering.

Release notes: https://github.com/kubernetes-sigs/kueue/releases/tag/v0.10.0

@ighosh98 ighosh98 merged commit 87cc26a into GoogleCloudPlatform:develop Dec 18, 2024
11 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-key-new-features Added to release notes under the "Key New Features" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants