Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lifecycle rule to ignore local SSDs #3450

Merged

Conversation

chajath
Copy link
Contributor

@chajath chajath commented Dec 20, 2024

These settings are known to be tied to machine types and sometimes API changes prompt change not best tracked by TF states

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

These settings are known to be tied to machine types and sometimes API
changes prompt change not best tracked by TF states
Copy link
Contributor

@ankitkinra ankitkinra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add to the PR description if this is recommended by GKE terraform provider ?

@ankitkinra ankitkinra added the release-improvements Added to release notes under the "Improvements" heading. label Dec 20, 2024
@ankitkinra
Copy link
Contributor

/gcbrun

@ighosh98
Copy link
Contributor

/gcbrun

@ighosh98 ighosh98 merged commit 517adbc into GoogleCloudPlatform:develop Dec 24, 2024
8 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants