Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A3 Ultra Integration tests #3453

Merged
merged 1 commit into from
Dec 21, 2024
Merged

A3 Ultra Integration tests #3453

merged 1 commit into from
Dec 21, 2024

Conversation

ighosh98
Copy link
Contributor

A basic integration test which spins up the cluster and runs a job successfully.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ighosh98 ighosh98 requested a review from ankitkinra December 20, 2024 22:25
@ighosh98 ighosh98 added the release-improvements Added to release notes under the "Improvements" heading. label Dec 20, 2024
@ighosh98 ighosh98 merged commit 66804e7 into GoogleCloudPlatform:develop Dec 21, 2024
8 of 63 checks passed
@ighosh98 ighosh98 deleted the a3u-integration-tests branch December 23, 2024 10:51
@RachaelSTamakloe RachaelSTamakloe mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitkinra ankitkinra ankitkinra approved these changes

Assignees
No one assigned
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ighosh98 @ankitkinra