Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update A3U blueprint to remove commit refs and remove hardcoded network names #3456

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

ighosh98
Copy link
Contributor

This change ties variable names to dynamic deployment_variables instead of hard coded values. This ensures that collisions do not occur when users use cluster-toolkit to provision multiple clusters within the same project.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ighosh98 ighosh98 requested a review from ankitkinra December 22, 2024 09:01
@ighosh98 ighosh98 added the release-improvements Added to release notes under the "Improvements" heading. label Dec 22, 2024
@ighosh98 ighosh98 changed the title Update A3U template design Update A3U blueprint to remove commit refs and remove hardcoded network names Dec 23, 2024
@ighosh98
Copy link
Contributor Author

Additional validations regarding variable length would be evaluated in a follow up PR. Merging this one to unblock other developers

@ighosh98 ighosh98 enabled auto-merge December 23, 2024 06:15
@ighosh98 ighosh98 merged commit 1d6cf29 into GoogleCloudPlatform:develop Dec 23, 2024
9 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants