Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove slurm-gcp v5 tests #3493

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Remove slurm-gcp v5 tests #3493

merged 1 commit into from
Jan 6, 2025

Conversation

harshthakkar01
Copy link
Contributor

@harshthakkar01 harshthakkar01 commented Jan 6, 2025 •
edited
Loading

Cloud Build triggers for slurm-gcp v5 are removed.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 added the release-deprecations Added to release notes under the "Deprecations" heading. label Jan 6, 2025
tpdownes
tpdownes approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpdownes tpdownes assigned harshthakkar01 and unassigned tpdownes Jan 6, 2025
@harshthakkar01 harshthakkar01 merged commit 62e2962 into GoogleCloudPlatform:develop Jan 6, 2025
10 of 55 checks passed
@RachaelSTamakloe RachaelSTamakloe mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

@mr0re1 mr0re1 Awaiting requested review from mr0re1

Assignees

@harshthakkar01 harshthakkar01

Labels
release-deprecations Added to release notes under the "Deprecations" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshthakkar01 @tpdownes