Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Slurm-gcp v5 modules and update documentation #3497

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Remove Slurm-gcp v5 modules and update documentation #3497

merged 1 commit into from
Jan 9, 2025

Conversation

harshthakkar01
Copy link
Contributor

@harshthakkar01 harshthakkar01 commented Jan 6, 2025 •
edited
Loading

This PR,

  • removes slurm-gcp v5 modules.
  • Updates documentations if they refer to v5.
  • Exclude examples to run validate tests if they use slurm-gcp v5.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 added the release-deprecations Added to release notes under the "Deprecations" heading. label Jan 6, 2025
@harshthakkar01 harshthakkar01 force-pushed the remove-v5-modules branch 9 times, most recently from 3473a84 to 6903f3a Compare January 8, 2025 19:56
@harshthakkar01 harshthakkar01 merged commit 23bfeb3 into GoogleCloudPlatform:develop Jan 9, 2025
8 of 52 checks passed
@RachaelSTamakloe RachaelSTamakloe mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

@tpdownes tpdownes Awaiting requested review from tpdownes

Assignees

@mr0re1 mr0re1

Labels
release-deprecations Added to release notes under the "Deprecations" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshthakkar01 @mr0re1