Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable optional creation of cloud router/nat for vpcs #3499

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Enable optional creation of cloud router/nat for vpcs #3499

merged 1 commit into from
Jan 9, 2025

Conversation

abbas1902
Copy link
Contributor

@abbas1902 abbas1902 commented Jan 6, 2025 •
edited
Loading

Main motivation is to decouple vpc and cloud router creation. By making it optional this will allow for the creation of IRDMA VPCs.

Also added validation to ensure that if Cloud NAT is enable Cloud Routers must also be enabled for the VPC.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 added the release-improvements Added to release notes under the "Improvements" heading. label Jan 6, 2025
@abbas1902 abbas1902 requested a review from tpdownes January 6, 2025 22:44
tpdownes
tpdownes requested changes Jan 7, 2025
View reviewed changes
modules/network/vpc/outputs.tf Outdated Show resolved Hide resolved
@tpdownes tpdownes assigned abbas1902 and unassigned tpdownes Jan 7, 2025
@abbas1902 abbas1902 force-pushed the vpc_glowup branch 2 times, most recently from 7e4450e to d4bdfb5 Compare January 7, 2025 17:43
@abbas1902 abbas1902 assigned tpdownes and unassigned abbas1902 Jan 7, 2025
@tpdownes tpdownes assigned abbas1902 and unassigned tpdownes Jan 9, 2025
@tpdownes tpdownes merged commit 110d820 into GoogleCloudPlatform:develop Jan 9, 2025
8 of 52 checks passed
@abbas1902 abbas1902 deleted the vpc_glowup branch January 9, 2025 17:32
@RachaelSTamakloe RachaelSTamakloe mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@abbas1902 abbas1902

Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abbas1902 @tpdownes