Add shielded instance config to default pool #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annuay-google
added
the
release-module-improvements
ankitkinra
reviewed
Jan 7, 2025
annuay-google
force-pushed
the
annuay/add-shielded-instance-config-to-default-pool
branch
from
d73a58e to
551a6c4
Compare
ankitkinra
approved these changes
Jan 7, 2025
annuay-google
merged commit 3213e22
into
GoogleCloudPlatform:develop
8 of 52 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
If a project has constraints/compute.requireShieldedVm enabled, then the default pool cannot be created and fails with
Current errors: [CONDITION_NOT_MET]: Instance 'gke-xyz-cluster-default-pool-...' creation failed: Constraint constraints/compute.requireShieldedVm violated for project projects/project-name.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.