Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version requirements #66

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

heyealex
Copy link
Contributor

@heyealex heyealex commented Dec 23, 2021

Add version requirements to documentation and add a check in the Makefile for Packer and Terraform

Submission Checklist:

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

Terraform 0.14
Packer 1.6.0
Verify Terraform exists and is greater than 0.14 and that Packer exists
and is greater than 1.6.0.
@heyealex heyealex merged commit 1bfd139 into GoogleCloudPlatform:develop Dec 23, 2021
@heyealex heyealex deleted the add-version-reqs branch December 23, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants