Add labels to resources/modules where missing #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Labels to components of resources that were previously missing them: * Boot disk for simple-instance * Project Factory * Startup script GCS bucket
cboneti
reviewed
Jan 25, 2022
| @@ -24,4 +24,6 @@ module "project_factory" { | |||
| org_id = var.org_id | |||
| billing_account = var.billing_account | |||
| default_service_account = var.default_service_account | |||
| labels = var.labels | |||
| bucket_labels = var.labels | |||
There was a problem hiding this comment.
since you are not creating a bucket, please do not set this.
If you do set this, then expose a variable called bucket_labels with a default null. And then assign this line to local.bucket_labels.
In the locals block:
bucket_labels = var.bucket_labels == null ? var.labels : var.bucket_labels
cboneti
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added labels to:
Terraform state bucket can't be added as we don't create a bucket, but rather use a pre-defined one.
Submission Checklist:
pre-commit installmake testschange?
guides?