Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -c flag from expand command #92

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Remove -c flag from expand command #92

merged 1 commit into from
Jan 27, 2022

Conversation

mittz
Copy link
Contributor

@mittz mittz commented Jan 27, 2022

This change has been tested with the following test cases. This is similar to Remove the -c flag for create and makes -c backwards compatible.

Case 1: ghpc expand help

This command doesn't show the -c flag in the list of flags as it's deprecated.

$ ./ghpc expand --help
Updates the YAML Config in the same way as create, but without writing the blueprint.

Usage:
  ghpc expand [flags]

Flags:
  -h, --help         help for expand
  -o, --out string   Output file for the expanded yaml. (default "expanded.yaml")

Case 2: ghpc expand without -c flag

Simple success.

$ ./ghpc expand examples/hpc-cluster-small.yaml 
Expanded config created successfully, saved as expanded.yaml.

$ ls expanded.yaml 
expanded.yaml

Case 3: ghpc expand with -c flag (Deprecation)

Success with the deprecation message.

$ ./ghpc expand -c examples/hpc-cluster-small.yaml
Flag --config has been deprecated, please see the command usage for more details.
Expanded config created successfully, saved as expanded.yaml.

$ ls expanded.yaml 
expanded.yaml

Submission Checklist:

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@mittz mittz requested a review from heyealex January 27, 2022 18:00
@cboneti cboneti merged commit 22df5ad into GoogleCloudPlatform:develop Jan 27, 2022
@mittz mittz deleted the remove-c-flag-from-expand branch January 28, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants