This repository has been archived by the owner on Aug 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Run Spring Inventory Manager with Cloud SQL, Secret Manager on App Engine flexible environment using Cloud Build #1277
Merged
ToddKopriva
merged 20 commits into
GoogleCloudPlatform:master
from
kioie:kioie-inventory-manager-tutorial
Jul 4, 2020
Merged
Run Spring Inventory Manager with Cloud SQL, Secret Manager on App Engine flexible environment using Cloud Build #1277
ToddKopriva
merged 20 commits into
GoogleCloudPlatform:master
from
kioie:kioie-inventory-manager-tutorial
Jul 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create tutorial folder for the Inventory Manager tutorial containing index file and tutorial assets.
Two Screenshot assets that will be used in the tutorial.
Updated editorial errors on the readme file.
Corrected editorial errors on the readme file.
Corrected the title removing the ' , ' illegal character.
Thanks for the submission. We're just returning from a long holiday weekend, so it may be a few days before this review is done. |
No worries, thanks for the heads up. |
hey @ToddKopriva, was this reviewed? |
It's in progress. |
No worries...thanks! |
ToddKopriva
approved these changes
Jul 4, 2020
Thanks for your review @ToddKopriva ! |
Thanks again for the contribution. |
This was referenced Apr 26, 2021
xiangshen-dk
pushed a commit
to xiangshen-dk/community
that referenced
this pull request
Jan 24, 2022
…gine flexible environment using Cloud Build (GoogleCloudPlatform#1277) * Create Spring Inventory Manager tutorial folder Create tutorial folder for the Inventory Manager tutorial containing index file and tutorial assets. * Uploaded screenshot assets for the tutorial Two Screenshot assets that will be used in the tutorial. * Tutorial A break-down of the process that runs the tutorial. * Updated readme file Updated editorial errors on the readme file. * Update readme file Corrected editorial errors on the readme file. * Remove comma character from the title Corrected the title removing the ' , ' illegal character. * updating image links * Update index.md * first edit pass through "Set up and test the application" * first edit pass through "Set up Secret Manager" * finished first edit pass * final edit * fixed code block Co-authored-by: Todd Kopriva <43478937+ToddKopriva@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tutorial discussing how to deploy Spring Inventory Manager Demo application to the App Engine flexible environment and use Cloud SQL, Secret Manager and Cloud Build.