This repository has been archived by the owner on Aug 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Deploying a private Godoc server on Kubernetes #1341
Merged
ToddKopriva
merged 7 commits into
GoogleCloudPlatform:master
from
richarddli:godoc-for-github
Jul 18, 2020
Merged
Deploying a private Godoc server on Kubernetes #1341
ToddKopriva
merged 7 commits into
GoogleCloudPlatform:master
from
richarddli:godoc-for-github
Jul 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the submission, @richarddli . There are a few other items in the queue, so it may be a couple of days before this gets reviewed. |
No problem, thank you @ToddKopriva! |
@ToddKopriva Just wanted to check to see if you had any feedback? Thanks! |
I'll be reviewing this today or tomorrow. |
I'll go back through with a more detailed edit on the second pass.
ToddKopriva
approved these changes
Jul 18, 2020
Thanks again for the tutorial, @richarddli . I'll publish this to cloud.google.com/community on Monday. |
Thank you! |
xiangshen-dk
pushed a commit
to xiangshen-dk/community
that referenced
this pull request
Jan 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tutorial shows how to deploy a simple private Godoc server on Kubernetes. Feedback welcome!