This repository has been archived by the owner on Aug 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add tutorial - Securing a static website hosted on Google Cloud Storage #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ptone, I added you as a reviewer after asking Xiang, since I see that you are a reviewer on the internal draft. I'll do the editorial and production review after the technical review is done. |
ptone
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical LGTM a few final clarity cleanups but leaving most of that to Todd
ToddKopriva
reviewed
Sep 24, 2020
I'll do a detailed second pass next.
ToddKopriva
approved these changes
Sep 24, 2020
xiangshen-dk
added a commit
to xiangshen-dk/community
that referenced
this pull request
Jan 24, 2022
…ge (GoogleCloudPlatform#1407) * add code for securing-gcs-static-website * add eslint file * update url map file * move credential to env vars * add index.md * update README * update readme * rename README to index * update based on review feedback * make lint happy * updated image links to public bucket * edited frontmatter * Google Cloud branding * beginning first line-edit pass * edited readme * Cloud Storage branding * line edit up through enabling APIs * fix enable api url * line edit through getting sample code * line edit up to configuring Cloud CDN * finished first editing pass I'll do a detailed second pass next. * Update index.md Co-authored-by: Todd Kopriva <43478937+ToddKopriva@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tutorial describes a solution to protect static assets on GCS based on the GCLB Serverless Network Endpoint Groups (NEGs).
Based on these docs:
go/secure-static-gcs-site
go/secure-static-gcs-site-tutorial