Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Updated App Engine Sidekiq + Rails tutorial to work with split health checks #1544

Merged
merged 9 commits into from
Dec 16, 2020
Merged

Updated App Engine Sidekiq + Rails tutorial to work with split health checks #1544

merged 9 commits into from
Dec 16, 2020

Conversation

MoHayat
Copy link
Contributor

@MoHayat MoHayat commented Dec 16, 2020

Hello -- I opened an issue a few days ago regarding the sidekiq tutorial being outdated and thought I'd submit the fixes that I made to get my background worker instance running and passing the health checks.

Specifically, here's what I changed with the tutorial:

  1. instructed users to save or copy password used for Redis instance and add it as an environment variable in app.yaml and worker.yaml, since the linked guide states that setting up a password is important to protecting the instance.
  2. in Option B of the deployments, added instructions to install and configure the sidekiq_alive gem to make the background worker instance pass the health checks. I also replaced the health_check attribute with liveness_check and readiness_check configurations, since health checks have been phased out
  3. added my github username in authors section to be tagged in case any future users had questions regarding my approach (am I allowed to do this?).

@google-cla
Copy link

google-cla bot commented Dec 16, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Dec 16, 2020
@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 16, 2020
@MoHayat
Copy link
Contributor Author

MoHayat commented Dec 16, 2020

@googlebot I signed it!

@ToddKopriva
Copy link
Member

Thanks for the fix. We'll review it soon.

@ToddKopriva
Copy link
Member

@chingor13 , could you have a look at this suggested fix for a document that you contributed?

@ToddKopriva
Copy link
Member

For reference, here is the issue report:
https://github.com/GoogleCloudPlatform/community/issues/1529

Copy link
Member

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I haven't worked with GAE flexible environment in quite some time.

@ToddKopriva
Copy link
Member

Thanks for the review, @chingor13 .

I'll do an editorial review and then merge the fix.

@ToddKopriva ToddKopriva merged commit fc7f03b into GoogleCloudPlatform:master Dec 16, 2020
@ToddKopriva
Copy link
Member

Thanks for the fix, @MoHayat .

I'll publish these changes within a couple of days.

@MoHayat
Copy link
Contributor Author

MoHayat commented Dec 16, 2020

Sounds great, I appreciate all the help!

xiangshen-dk pushed a commit to xiangshen-dk/community that referenced this pull request Jan 24, 2022
… checks (GoogleCloudPlatform#1544)

* updated sidekiq appengine tutorial to work with split health checks

* Update appengine-ruby-rails-activejob-sidekiq.md

* fixed language, addered service attribute back to worker.yam

* grammer tweak

* spcing fix

* used correct terminology for worker.yaml description

* edit pass

Co-authored-by: Todd Kopriva <43478937+ToddKopriva@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants