-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Updated App Engine Sidekiq + Rails tutorial to work with split health checks #1544
Updated App Engine Sidekiq + Rails tutorial to work with split health checks #1544
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for the fix. We'll review it soon. |
@chingor13 , could you have a look at this suggested fix for a document that you contributed? |
For reference, here is the issue report: |
…oHayat/community into fix-appengine-sidekiq-tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I haven't worked with GAE flexible environment in quite some time.
Thanks for the review, @chingor13 . I'll do an editorial review and then merge the fix. |
Thanks for the fix, @MoHayat . I'll publish these changes within a couple of days. |
Sounds great, I appreciate all the help! |
… checks (GoogleCloudPlatform#1544) * updated sidekiq appengine tutorial to work with split health checks * Update appengine-ruby-rails-activejob-sidekiq.md * fixed language, addered service attribute back to worker.yam * grammer tweak * spcing fix * used correct terminology for worker.yaml description * edit pass Co-authored-by: Todd Kopriva <43478937+ToddKopriva@users.noreply.github.com>
Hello -- I opened an issue a few days ago regarding the sidekiq tutorial being outdated and thought I'd submit the fixes that I made to get my background worker instance running and passing the health checks.
Specifically, here's what I changed with the tutorial:
app.yaml
andworker.yaml
, since the linked guide states that setting up a password is important to protecting the instance.sidekiq_alive
gem to make the background worker instance pass the health checks. I also replaced thehealth_check
attribute withliveness_check
andreadiness_check
configurations, since health checks have been phased out