Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Automatic data tokenization tutorial initial commit. #1550

Merged
merged 25 commits into from
Jan 11, 2021
Merged

Automatic data tokenization tutorial initial commit. #1550

merged 25 commits into from
Jan 11, 2021

Conversation

anantdamle
Copy link
Contributor

@ktchana can you please peer review.

@google-cla google-cla bot added the cla: yes label Dec 21, 2020
@anantdamle
Copy link
Contributor Author

@ToddKopriva The title checking regex does not seem to allow commas in the title. I think it needs to be updated to permit commas.

@ToddKopriva ToddKopriva self-requested a review December 21, 2020 17:13
@ToddKopriva
Copy link
Member

@ToddKopriva The title checking regex does not seem to allow commas in the title. I think it needs to be updated to permit commas.

I'll see whether that might cause other problems, and I'll update the test.

@ToddKopriva ToddKopriva self-assigned this Dec 21, 2020
Copy link
Contributor

@ktchana ktchana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changes recommended

tutorials/auto-data-tokenize/index.md Outdated Show resolved Hide resolved
tutorials/auto-data-tokenize/index.md Outdated Show resolved Hide resolved
tutorials/auto-data-tokenize/index.md Outdated Show resolved Hide resolved
tutorials/auto-data-tokenize/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ktchana ktchana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ToddKopriva
Copy link
Member

Thanks for the review, @ktchana .

I'll do the editorial and production review soon.

@anantdamle
Copy link
Contributor Author

@ToddKopriva the linter is failing. Do advise on the title rules to contain commas.

@ToddKopriva
Copy link
Member

@ToddKopriva the linter is failing. Do advise on the title rules to contain commas.

I updated the test to allow commas.

You also had an error in the author metadata (trailing space). I fixed that.

@ToddKopriva ToddKopriva merged commit 5858547 into GoogleCloudPlatform:master Jan 11, 2021
@anantdamle anantdamle deleted the auto-data-tokenize branch January 12, 2021 00:42
@ToddKopriva
Copy link
Member

xiangshen-dk pushed a commit to xiangshen-dk/community that referenced this pull request Jan 24, 2022
…form#1550)

* Automatic data tokenization tutorial initial commit.

* Formatted flattening record bullet

* Add explanation for use of DAEAD

* Fix review comments

* fix duplicate section.

* Update explanation and naming

* Add bin icon

* Add bin icon

* fix typo1

* Fix typos and some grammar issues

* fixing author metadata

* Update pipeline parameter names

* updated frontmatter and image links

* edit pass up to "Before you begin"

merged redundant prerequisistes and objectives section

* edit through "Creating resources"

* edited through "Compile modules"

* finished first edit pass

* final proofreading pass

Co-authored-by: Todd Kopriva <43478937+ToddKopriva@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants