Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Updated cloud-iot-logging tutorial issues #1567

Merged
merged 7 commits into from
Feb 3, 2021

Conversation

jos-
Copy link
Contributor

@jos- jos- commented Jan 4, 2021

  • Upgraded some dependencies
  • Updated code for latest version of sdk
  • Linter fixes
  • Renamed Stackdriver to Cloud Logging

Fixed bugs and typo in index.md
Fixed bugs and typo in index.ts
@google-cla
Copy link

google-cla bot commented Jan 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 4, 2021
@jos- jos- changed the title Updated cloud logging tutorial issues Updated cloud-iot-logging tutorial issues Jan 4, 2021
@ToddKopriva
Copy link
Member

Thanks for the fixes, @jos- .

@ptone , could you have a look at these fixes for some code that you submitted?

Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gguuss
Copy link
Contributor

gguuss commented Jan 5, 2021

We'll just need the CLA check and this should be good to go :)

@ToddKopriva
Copy link
Member

@jos- , as @gguuss says, we just need you to follow the google-cla bot's instructions to sign the CLA.

Thanks again for the fixes.

@ToddKopriva ToddKopriva assigned ToddKopriva and unassigned ptone Jan 5, 2021
@ToddKopriva ToddKopriva removed the request for review from ptone January 5, 2021 22:35
@google-cla
Copy link

google-cla bot commented Jan 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ToddKopriva ToddKopriva assigned jos- and unassigned ToddKopriva Jan 9, 2021
@google-cla
Copy link

google-cla bot commented Jan 28, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ToddKopriva
Copy link
Member

@jos- , we're ready to merge this pull request if you accept the contributor license agreement.

Let us know whether you want to move forward with this pull request.

@google-cla
Copy link

google-cla bot commented Feb 2, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gguuss
Copy link
Contributor

gguuss commented Feb 2, 2021

@jos- Friendly ping to sign the CLA.

@google-cla
Copy link

google-cla bot commented Feb 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jos-
Copy link
Contributor Author

jos- commented Feb 3, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 3, 2021
@ToddKopriva ToddKopriva merged commit be13984 into GoogleCloudPlatform:master Feb 3, 2021
@ToddKopriva
Copy link
Member

Thanks, @jos- .

xiangshen-dk pushed a commit to xiangshen-dk/community that referenced this pull request Jan 24, 2022
* Update index.md

Fixed bugs and typo in index.md

* Update index.ts

Fixed bugs and typo in index.ts

* Upgraded dependencies

Co-authored-by: Todd Kopriva <43478937+ToddKopriva@users.noreply.github.com>
Co-authored-by: Jason Dobry <jmdobry@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants