Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Adds Laravel tutorial for App Engine Standard PHP 7.2 #658

Merged
merged 10 commits into from
Jan 31, 2019

Conversation

bshaffer
Copy link
Contributor

No description provided.

markdown fixes

markdown fixes

markdown fixes

markdown fixes

markdown testing

markdown testing

markdown testing

markdown testing
Copy link
Member

@ToddKopriva ToddKopriva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in great shape. Just a few review comments from me.

## Deploy

1. Create an `app.yaml` file with the following contents:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our publishing process doesn't currently deal well with code fences inside lists, so I'll need to switch this codeblock to just use indentation. I can do this during the production pass, so there's nothing required from you here now. I'm just letting you know what to expect.

tutorials/run-laravel-on-appengine-standard/index.md Outdated Show resolved Hide resolved
tutorials/run-laravel-on-appengine-standard/index.md Outdated Show resolved Hide resolved
@bshaffer
Copy link
Contributor Author

@ToddKopriva Fixed the requested issues!

bshaffer and others added 3 commits January 31, 2019 11:36
converting codeblocks to use indentation required by our quirky publishing process
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants