Add tooling for policy library organization. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgante
suggested changes
Aug 21, 2019
pkg/bundlemanager/util.go
Outdated
| var bundlePrefix = "bundles.validator.forsetisecurity.org/" | ||
|
|
||
| // BundleAnnotation | ||
| func BundleAnnotation(key string) bool { |
There was a problem hiding this comment.
Should we call this HasBundleAnnotation?
There was a problem hiding this comment.
works for me, done
pkg/bundlemanager/util.go
Outdated
| }) | ||
| } | ||
|
|
||
| func ctsToStrs( |
There was a problem hiding this comment.
This name is unclear - could we make a more descriptive one?
There was a problem hiding this comment.
yes, this name is horrible. done.
morgante
approved these changes
Aug 22, 2019
briantkennedy
force-pushed
the
policy-tool
branch
from
78af0a2
to
83774db
Compare
briantkennedy
force-pushed
the
policy-tool
branch
from
83774db
to
604bd46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@morgante please take a look.