Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup containerized build #251

Merged

Conversation

kurt-google
Copy link
Collaborator

We did not prepare the environment correctly so it was out of sync with prow and other environments using the same container. This adds in the call the install_prow_deps.sh to ensure it is correct.

Change-Id: I97cf5ea9393e9eedb25c30573bac454f3d8d9836

We did not prepare the environment correctly so it was out of sync with
prow and other environments using the same container. This adds in the
call the install_prow_deps.sh to ensure it is correct.

Change-Id: I97cf5ea9393e9eedb25c30573bac454f3d8d9836
Copy link
Collaborator

@akinfermo akinfermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akinfermo, kurt-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurt-google kurt-google merged commit 81ad530 into GoogleCloudPlatform:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants