Skip to content

Commit

Permalink
Remove the response-server-ws-gcloud-key user-registration-server-ws-…
Browse files Browse the repository at this point in the history
…gcloud-key secrets

These aren't needed, as these apps can use the GKE credentials.
See https://cloud.google.com/docs/authentication/production
  • Loading branch information
MartinPetkov committed Apr 16, 2020
1 parent aff23ec commit 6c38d0f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
9 changes: 0 additions & 9 deletions response-server-ws/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,12 @@ spec:
value: "study-meta-data-np:50000"
- name: REGISTRATION_SERVER_URL
value: "user-registration-server-np:60000"
- name: GOOGLE_APPLICATION_CREDENTIALS
value: "/secrets/gcloud_key/key.json"
ports:
- containerPort: 8080
readinessProbe:
httpGet:
path: /mystudies-response-server/health
port: 8080
volumeMounts:
- name: gcloud-key-volume
mountPath: /secrets/gcloud_key
readOnly: true
- name: cloudsql-proxy
image: gcr.io/cloudsql-docker/gce-proxy:latest
command: ["/cloud_sql_proxy",
Expand All @@ -86,6 +80,3 @@ spec:
- name: my-secrets-volume
secret:
secretName: cloudsql-instance-credentials
- name: gcloud-key-volume
secret:
secretName: response-server-ws-gcloud-key
9 changes: 0 additions & 9 deletions user-registration-server-ws/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,12 @@ spec:
value: "dummy-value"
- name: GCP_BUCKET_NAME
value: "heroes-hat-dev-data-my-study-consent-documents"
- name: GOOGLE_APPLICATION_CREDENTIALS
value: "/secrets/gcloud_key/key.json"
ports:
- containerPort: 8080
readinessProbe:
httpGet:
path: /myStudiesUserMgmtWS/healthCheck
port: 8080
volumeMounts:
- name: gcloud-key-volume
mountPath: /secrets/gcloud_key
readOnly: true
- name: cloudsql-proxy
image: gcr.io/cloudsql-docker/gce-proxy:latest
command: ["/cloud_sql_proxy",
Expand All @@ -78,6 +72,3 @@ spec:
- name: my-secrets-volume
secret:
secretName: cloudsql-instance-credentials
- name: gcloud-key-volume
secret:
secretName: user-registration-server-ws-gcloud-key

0 comments on commit 6c38d0f

Please sign in to comment.