Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple DB credentials and roles/cloudsql.client for the GKE SAs #161

Merged
merged 5 commits into from
Apr 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,4 @@ module "my_studies_cloudsql" {
verify_server_certificate = null
}
}

Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
output "instance_name" {
value = module.my_studies_cloudsql.instance_name
}

# This is not outputted by the safer_sql module, but allow dependents to treat
# it like it is.
output "instance_user" {
value = "default"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
# Create a separate user for each app, generate a password, and store in secrets
locals {
apps = [
"auth-server",
"response-server",
"study-designer",
"study-meta-data",
"user-registration",
]
}

resource "random_password" "db_passwords" {
for_each = toset(local.apps)

length = 16
special = true
}

resource "google_sql_user" "db_users" {
for_each = toset(local.apps)

name = "${each.key}-db-user"
instance = module.my_studies_cloudsql.instance_name
host = "%"
password = random_password.db_passwords[each.key].result
}

resource "google_secret_manager_secret" "db_passwords_secrets" {
provider = google-beta

for_each = toset(local.apps)

secret_id = "${each.key}-db-password"
project = var.project_id

replication {
automatic = true
}
}

resource "google_secret_manager_secret" "db_users_secrets" {
provider = google-beta

for_each = toset(local.apps)

secret_id = "${each.key}-db-user"
project = var.project_id

replication {
automatic = true
}
}

resource "google_secret_manager_secret_version" "db_passwords_secrets_values" {
provider = google-beta

for_each = toset(local.apps)

secret = google_secret_manager_secret.db_passwords_secrets[each.key].id
secret_data = random_password.db_passwords[each.key].result
}

resource "google_secret_manager_secret_version" "db_users_secrets_values" {
provider = google-beta

for_each = toset(local.apps)

secret = google_secret_manager_secret.db_users_secrets[each.key].id
secret_data = google_sql_user.db_users[each.key].name
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ dependency "apps" {

mock_outputs = {
service_account = "mock-gke-service-account"
apps_service_accounts = {
mock-app = "mock-app-gke@mock-project.iam.gserviceaccount.com"
}
}
}

Expand All @@ -38,8 +41,10 @@ dependency "networks" {
}

inputs = {
sql_client_service_accounts = [
dependency.apps.outputs.service_account,
dependency.networks.outputs.bastion_service_account,
]
sql_client_service_accounts = concat(
[
dependency.apps.outputs.service_account,
dependency.networks.outputs.bastion_service_account,
],
values(dependency.apps.outputs.apps_service_accounts)[*].email)
}