Merge terraform into early access #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This config hasn't been tested yet.
Also adjust variables from "network_name" to just "network" and use the "network_self_link" output instead of "network_name".
Add network project in org policy.
Also combine the GKE subnet definition into main.tf
Move the GKE clusters into the same subnet
umairidris
approved these changes
Apr 21, 2020
zohrehj
reviewed
Apr 21, 2020
Terraform/org/folder.fda-my-studies/project.heroes-hat-dev-apps/apps/main.tf
Show resolved
Hide resolved
Terraform/org/folder.fda-my-studies/project.heroes-hat-dev-apps/apps/terraform.tfvars
Show resolved
Hide resolved
Terraform/org/folder.fda-my-studies/project.heroes-hat-dev-apps/project/terraform.tfvars
Show resolved
Hide resolved
kuoyuchi
reviewed
Apr 22, 2020
kuoyuchi
reviewed
Apr 22, 2020
kuoyuchi
reviewed
Apr 22, 2020
kuoyuchi
reviewed
Apr 22, 2020
kuoyuchi
reviewed
Apr 22, 2020
zohrehj
approved these changes
Apr 22, 2020
|
I've opened #204 to address some of the comments. |
This is recommended by https://cloud.google.com/istio/docs/istio-on-gke/installing#installing_istio_on_gke_2 The annotations method comes from https://istio.io/docs/setup/additional-setup/sidecar-injection/#policy Co-authored-by: Martin Petkov <mpetkov@google.com>
Changes: * Remove .json keys from .gitignore, since they're no longer manually managed. * Move the audit bucket to us-east1 like all the other resources. * Replace a CLIENT_ID with a dummy test value in a k8s deployment. * Use the right port for the user-registration-server-np. * Fork the k8s deployment.yaml files, to avoid clobbering the working ones. Co-authored-by: Martin Petkov <mpetkov@google.com>
…-added immediately." This reverts commit 756498a.
This reverts commit dcc781b.
|
Note about the stuck builds: I found [this]:(https://help.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-events-for-forked-repositories) Since this is proposed from my fork, these builds won't run, and I don't yet know how to trigger them. |
|
I just found this too: https://git.luolix.topmunity/t5/GitHub-Actions/Will-GitHub-Actions-support-pull-request-events-from-a-fork-to-a/td-p/44488/page/3 Which seems like this just isn't a supported feature, and there's no roadmap to support it yet. I'll just have to submit without running the checks. |
* Remove workflows to try to get GitHub to see them. Will be re-added immediately. * Revert "Remove workflows to try to get GitHub to see them. Will be re-added immediately." This reverts commit 756498a. * Remove the whole .github/ dir. Will readd immediately. * Revert "Remove the whole .github/ dir. Will readd immediately." This reverts commit dcc781b. * Create a static external IP for the Ingress GKE can create an external IP automatically, but it may change if the ingress is deleted and recreated. Instead, create one in Terraform, and always use the same one in the Ingress. Co-authored-by: Martin Petkov <mpetkov@google.com>
* Remove workflows to try to get GitHub to see them. Will be re-added immediately. * Revert "Remove workflows to try to get GitHub to see them. Will be re-added immediately." This reverts commit 756498a. * Remove the whole .github/ dir. Will readd immediately. * Revert "Remove the whole .github/ dir. Will readd immediately." This reverts commit dcc781b. * Change Ingress static IP to global Looking again at the instructions at https://cloud.google.com/kubernetes-engine/docs/tutorials/configuring-domain-name-static-ip, this address should be global. Co-authored-by: Martin Petkov <mpetkov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.