-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge terraform into early access #202
Merge terraform into early access #202
Conversation
This config hasn't been tested yet.
Also adjust variables from "network_name" to just "network" and use the "network_self_link" output instead of "network_name".
Add network project in org policy.
Also combine the GKE subnet definition into main.tf
Move the GKE clusters into the same subnet
Terraform/org/folder.fda-my-studies/project.heroes-hat-dev-apps/apps/main.tf
Show resolved
Hide resolved
Terraform/org/folder.fda-my-studies/project.heroes-hat-dev-apps/apps/terraform.tfvars
Show resolved
Hide resolved
Terraform/org/folder.fda-my-studies/project.heroes-hat-dev-apps/project/terraform.tfvars
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting this up! A few minor comments.
I've opened #204 to address some of the comments. |
This is recommended by https://cloud.google.com/istio/docs/istio-on-gke/installing#installing_istio_on_gke_2 The annotations method comes from https://istio.io/docs/setup/additional-setup/sidecar-injection/#policy Co-authored-by: Martin Petkov <mpetkov@google.com>
Changes: * Remove .json keys from .gitignore, since they're no longer manually managed. * Move the audit bucket to us-east1 like all the other resources. * Replace a CLIENT_ID with a dummy test value in a k8s deployment. * Use the right port for the user-registration-server-np. * Fork the k8s deployment.yaml files, to avoid clobbering the working ones. Co-authored-by: Martin Petkov <mpetkov@google.com>
…-added immediately." This reverts commit 756498a.
This reverts commit dcc781b.
Note about the stuck builds: I found [this]:(https://help.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-events-for-forked-repositories)
Since this is proposed from my fork, these builds won't run, and I don't yet know how to trigger them. |
I just found this too: https://git.luolix.topmunity/t5/GitHub-Actions/Will-GitHub-Actions-support-pull-request-events-from-a-fork-to-a/td-p/44488/page/3 Which seems like this just isn't a supported feature, and there's no roadmap to support it yet. I'll just have to submit without running the checks. |
* Remove workflows to try to get GitHub to see them. Will be re-added immediately. * Revert "Remove workflows to try to get GitHub to see them. Will be re-added immediately." This reverts commit 756498a. * Remove the whole .github/ dir. Will readd immediately. * Revert "Remove the whole .github/ dir. Will readd immediately." This reverts commit dcc781b. * Create a static external IP for the Ingress GKE can create an external IP automatically, but it may change if the ingress is deleted and recreated. Instead, create one in Terraform, and always use the same one in the Ingress. Co-authored-by: Martin Petkov <mpetkov@google.com>
* Remove workflows to try to get GitHub to see them. Will be re-added immediately. * Revert "Remove workflows to try to get GitHub to see them. Will be re-added immediately." This reverts commit 756498a. * Remove the whole .github/ dir. Will readd immediately. * Revert "Remove the whole .github/ dir. Will readd immediately." This reverts commit dcc781b. * Change Ingress static IP to global Looking again at the instructions at https://cloud.google.com/kubernetes-engine/docs/tutorials/configuring-domain-name-static-ip, this address should be global. Co-authored-by: Martin Petkov <mpetkov@google.com>
No description provided.