Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/275691446/update project requirements #13

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

soulless-viewer
Copy link
Collaborator

Description

This PR was opened to clarify our project requirements.
Not all of them are accurate and justified, which can cause bugs or at least misunderstandings.

Changes

  1. Minimum required Python version was downgraded from 3.9 (unjustified) to 3.7
  2. The Python version used in GitHub flow was also set as 3.7 to test on the oldest version
  3. Minimum required google-api-python-client version was set as 2.68.0 *
    • Technically, the version should be at least 2.1.0, since it introduced resources on which we depend. However, it was decided to use the version that came out on a par with the beginning of our development
  4. Minimum required google-auth version was set as 2.15.0 *
    • Also, it was decided to use the version that came out on a par with the beginning of our development

README.md Show resolved Hide resolved
Copy link
Collaborator

@halleysouza halleysouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please have a look on the README.md comment.

@halleysouza halleysouza dismissed their stale review October 5, 2023 08:05

change will be addressed in a separated PR

Copy link
Collaborator

@halleysouza halleysouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@halleysouza halleysouza merged commit 38667d4 into main Oct 5, 2023
6 checks passed
@halleysouza halleysouza deleted the feature/275691446/update-project-requirements branch October 5, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants