Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add extension v 0.1 #108

Merged
merged 9 commits into from
Jun 10, 2022
Merged

feat: Add extension v 0.1 #108

merged 9 commits into from
Jun 10, 2022

Conversation

saranshdhingra
Copy link
Contributor

No description provided.

@saranshdhingra saranshdhingra requested a review from a team as a code owner May 6, 2022 09:30
@github-actions
Copy link

github-actions bot commented May 6, 2022

PR staged at https://pr-108-e73eee19fbdf700cc16ba539c963f40e172fc176-5tkroniexa-uc.a.run.app

@github-actions
Copy link

github-actions bot commented May 6, 2022

PR staged at https://pr-108-2016e7527b333adb1338eec6dfdf713e92cf26e9-5tkroniexa-uc.a.run.app

enocom
enocom reviewed May 25, 2022
View reviewed changes
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few high level thoughts:

  • Can we add some tests for this?
  • Would it be possible to have the extension use the same code as the webapp for pinging regions?
  • Let's run prettier and jslint on this.
  • What if we wrote this in TypeScript?

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

PR staged at https://pr-108-4e7893cfb0e64c139ba5709cd0e075215694ed64-5tkroniexa-uc.a.run.app

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

PR staged at https://pr-108-b55e5476a7962ca16ea339ef135b95c0a9ba6bd0-5tkroniexa-uc.a.run.app

enocom
enocom approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A README in the ext directory would be nice explaining what this is, how it's built, etc.

ext/js/service-worker.js Outdated Show resolved Hide resolved
ext/js/service-worker.js Show resolved Hide resolved
ext/js/service-worker.js Outdated Show resolved Hide resolved
@github-actions
Copy link

PR staged at https://pr-108-59da6250ed117e936bb06e027f27cf99e0739981-5tkroniexa-uc.a.run.app

@github-actions
Copy link

PR staged at https://pr-108-7de165d153f83aa8beaa9631a7f3d844ae0c8963-5tkroniexa-uc.a.run.app

@saranshdhingra saranshdhingra merged commit 216e124 into main Jun 10, 2022
@saranshdhingra saranshdhingra deleted the add-extension branch June 10, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saranshdhingra @enocom