Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ashmeenkaur committed Apr 2, 2024
1 parent b7feb33 commit e87de39
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion internal/fs/local_file_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ func (t *LocalFileTest) newFileShouldGetSyncedToGCSAtClose(fileName string) {
AssertNe(nil, extendedAttr)
AssertNe(nil, minObject)
ExpectFalse(reflect.DeepEqual(*extendedAttr, gcs.ExtendedObjectAttributes{}))
ExpectFalse(reflect.DeepEqual(*minObject, gcs.ExtendedObjectAttributes{}))
ExpectFalse(reflect.DeepEqual(*minObject, gcs.MinObject{}))
}

func (t *LocalFileTest) validateNoFileOrDirError(filename string) {
Expand Down
1 change: 0 additions & 1 deletion internal/fs/local_modifications_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1541,7 +1541,6 @@ func validateObjectAttributes(extendedAttr1, extendedAttr2 *gcs.ExtendedObjectAt
attr1MTime, _ := time.Parse(time.RFC3339Nano, minObject1.Metadata[gcsx.MtimeMetadataKey])
attr2MTime, _ := time.Parse(time.RFC3339Nano, minObject2.Metadata[gcsx.MtimeMetadataKey])
ExpectTrue(attr1MTime.Before(attr2MTime))
fmt.Println(attr1MTime, "...", attr2MTime)
ExpectEq(minObject1.ContentEncoding, minObject2.ContentEncoding)

// Validate Extended Object Attributes.
Expand Down

0 comments on commit e87de39

Please sign in to comment.