Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting O_DIRECT flag in Integration tests #1041

Merged
merged 21 commits into from
Apr 4, 2023
Merged

Setting O_DIRECT flag in Integration tests #1041

merged 21 commits into from
Apr 4, 2023

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Apr 3, 2023 •
edited
Loading

Description

Currently we are using linux command to clear the cache, instead we should replace with the O_DIRECT flag while reading any file.
os.OpenFile(name, syscall.O_DIRECT)

Testing

  1. Manual - checked gcsfuse.log. not reading from kernal. Integration tests are working fine for both the cases(testbucket and MountDir)
  2. UnitTest - N/A
  3. IntegrationTest - N/A

@Tulsishah Tulsishah changed the title [Don't Review]O_direct flag Setting O_direct flag Apr 3, 2023
@Tulsishah Tulsishah changed the title Setting O_direct flag [Don't Review] Setting O_direct flag Apr 3, 2023
@Tulsishah Tulsishah changed the title [Don't Review] Setting O_direct flag Setting O_direct flag in Integration tests Apr 3, 2023
@Tulsishah Tulsishah requested a review from raj-prince April 3, 2023 13:50
@Tulsishah Tulsishah changed the title Setting O_direct flag in Integration tests Setting O_DIRECT flag in Integration tests Apr 3, 2023
raj-prince
raj-prince reviewed Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

@Tulsishah Tulsishah requested a review from raj-prince April 4, 2023 05:17
@Tulsishah
Copy link
Collaborator Author

Minor comments.

Fixed

@Tulsishah Tulsishah merged commit f54dfad into GoogleCloudPlatform:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tulsishah @raj-prince