Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pip installation vulnerability in ls_metrics script #1095

Merged

Conversation

raj-prince
Copy link
Collaborator

@raj-prince raj-prince commented May 7, 2023

Description

One of the vulnerabilities was to install the python module dependency by enabling the check-sum. Hence, we would need to keep the hash for the pip dependencies.

Steps:

  1. Create a requirements.in file with all the python dependency.
  2. Use pip-compile requirements.in this will generated requirement.txt with hash.
  3. Use pip install --require-hash -r requirements.txt to install the dependency.

Link to the issue in case of a bug fix.

Testing details

  1. Manual - Manually verified by running the script offline. End to end test (upload workflow) will happen as a part of CI/CD.
  2. Unit tests
  3. Integration tests

@raj-prince raj-prince requested review from Tulsishah and sethiay May 10, 2023 05:22
@raj-prince raj-prince merged commit e3858de into GoogleCloudPlatform:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants