Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move File Integration test #1097

Merged
merged 31 commits into from
May 12, 2023

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented May 8, 2023

This will be pull request template

Description

Adding Integration tests for moving file.

  1. Within same directory
  2. Within different directory

Link to the issue in case of a bug fix.

Testing details

  1. Manual - All the tests are passing
  2. Unit tests - N/A
  3. Integration tests - All the tests from integration tests directory working fine together.

@Tulsishah Tulsishah changed the title [Don't Review]Move file test Move file Integration test May 8, 2023
@Tulsishah Tulsishah changed the title Move file Integration test Move File Integration test May 8, 2023
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments...

@Tulsishah Tulsishah requested a review from raj-prince May 11, 2023 10:24
@raj-prince
Copy link
Collaborator

Changes look fine.
Are we covering rename file case using the mv command, E.g. mv a.txt b.txt? It's same as moving within the same directory with different file-name.

@Tulsishah
Copy link
Collaborator Author

ring rename file case using the

Yes it is

Changes look fine. Are we covering rename file case using the mv command, E.g. mv a.txt b.txt? It's same as moving within the same directory with different file-name.

Isn't it the case to rename the file - mentioned in this test case

Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment - please incorporate before merging.

@Tulsishah Tulsishah merged commit 02cef55 into GoogleCloudPlatform:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants