Upgrade to golang 1.22 #1753
Merged
Upgrade to golang 1.22 #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gargnitingoogle
added
execute-perf-test
gargnitingoogle
requested review from
sethiay,
vadlakondaswetha and
raj-prince
as code owners
To address the following build errors in ci workflow: Autobuilder was built with go1.21.7, environment has go1.21.7. Error: We were unable to automatically build your code. Please replace the call to the autobuild action with your custom build steps. Encountered a fatal error while running "/opt/hostedtoolcache/CodeQL/2.16.3/x64/codeql/go/tools/autobuild.sh". Exit code was 1 and last log line was: 2024/02/28 18:16:40 Extraction failed: exit status 1. See the logs for more details.
This reverts commit 9b6bbbf.
gargnitingoogle
added
execute-perf-test
gargnitingoogle
commented
Feb 28, 2024
ashmeenkaur
reviewed
Feb 29, 2024
gargnitingoogle
added
execute-perf-test
ashmeenkaur
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Approval for code changes.
Would request @sethiay or @raj-prince to check perf tests once. Overall from all the runs, I think the regression is not because of the PR changes.
sethiay
approved these changes
Mar 4, 2024
gargnitingoogle
added a commit
that referenced
this pull request
Mar 5, 2024
This reverts commit 3adecdf.
gargnitingoogle
added a commit
that referenced
this pull request
Mar 5, 2024
gargnitingoogle
added a commit
that referenced
this pull request
Mar 5, 2024
gargnitingoogle
added a commit
that referenced
this pull request
Mar 5, 2024
gargnitingoogle
added a commit
that referenced
this pull request
Mar 6, 2024
gargnitingoogle
added a commit
that referenced
this pull request
Mar 12, 2024
* Upgrade to golang 1.22 (without dockerfile fix) Reapply "Upgrade to golang 1.22 (#1753)" (#1766) This reverts commit a63a46f and fixes merge conflicts with golang 1.21.7 upgrade which went in earlier. * Fix containerize_gcsfuse/dockerfile for go 1.22 Does the following 1. Create a go module (go.mod) in a directory package_gcsfuse, to bypass the change in go get behaviour introduced in 1.17 and enforced in go 1.22. 2. Fix some paths and commands etc. accordingly in the dockerfile. * Fix package_gcsfuse/dockerfile for go 1.22 Does the following 1. Create a go module (go.mod) in a directory package_gcsfuse, to bypass the change in go get behaviour introduced in 1.17 and enforced in go 1.22. 2. Fix some paths and commands etc. accordingly in the dockerfile. * Switch containerize*/Dockerfile to use git clone * Switch package*/Dockerfile to use git clone * Replace /go with ${GOPATH} * Minimize run of git clone Fetch only the last commit state in docker files during git clone to reduce its runtime. This reduces the runtime of git clone dramatically. * Upgrade from go 1.22.0 to 1.22.1
Tulsishah
pushed a commit
that referenced
this pull request
Mar 15, 2024
* Upgrade to golang 1.22 (without dockerfile fix) Reapply "Upgrade to golang 1.22 (#1753)" (#1766) This reverts commit a63a46f and fixes merge conflicts with golang 1.21.7 upgrade which went in earlier. * Fix containerize_gcsfuse/dockerfile for go 1.22 Does the following 1. Create a go module (go.mod) in a directory package_gcsfuse, to bypass the change in go get behaviour introduced in 1.17 and enforced in go 1.22. 2. Fix some paths and commands etc. accordingly in the dockerfile. * Fix package_gcsfuse/dockerfile for go 1.22 Does the following 1. Create a go module (go.mod) in a directory package_gcsfuse, to bypass the change in go get behaviour introduced in 1.17 and enforced in go 1.22. 2. Fix some paths and commands etc. accordingly in the dockerfile. * Switch containerize*/Dockerfile to use git clone * Switch package*/Dockerfile to use git clone * Replace /go with ${GOPATH} * Minimize run of git clone Fetch only the last commit state in docker files during git clone to reduce its runtime. This reduces the runtime of git clone dramatically. * Upgrade from go 1.22.0 to 1.22.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to golang 1.22
Link to the issue in case of a bug fix.
NA
Testing details