Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composite test for min object changes #1811

Merged
merged 3 commits into from
Apr 2, 2024
Merged

composite test for min object changes #1811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce5b6fd
composite test for min object changes
ashmeenkaur Mar 26, 2024
b7feb33
lint fixes
ashmeenkaur Mar 26, 2024
e87de39
review comments
ashmeenkaur Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/fs/local_file_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"os"
"path"
"path/filepath"
"reflect"
"strings"
"time"

Expand All @@ -44,6 +45,7 @@ const FileName2 = "foo2"
const implicitLocalFileName = "implicitLocalFile"
const explicitLocalFileName = "explicitLocalFile"
const FileContents = "teststring"
const FileContentsSize = 10
const Delta = 30 * time.Minute

type LocalFileTest struct {
Expand Down Expand Up @@ -145,6 +147,14 @@ func (t *LocalFileTest) newFileShouldGetSyncedToGCSAtClose(fileName string) {

// Close the file and validate if the file is created on GCS.
t.closeFileAndValidateObjectContents(&t.f1, fileName, FileContents)

// Validate object attributes non-nil and non-empty.
minObject, extendedAttr, err := bucket.StatObject(ctx, &gcs.StatObjectRequest{Name: fileName, ForceFetchFromGcs: true, ReturnExtendedObjectAttributes: true})
AssertEq(nil, err)
AssertNe(nil, extendedAttr)
AssertNe(nil, minObject)
ExpectFalse(reflect.DeepEqual(*extendedAttr, gcs.ExtendedObjectAttributes{}))
ExpectFalse(reflect.DeepEqual(*minObject, gcs.MinObject{}))
}

func (t *LocalFileTest) validateNoFileOrDirError(filename string) {
Expand Down
87 changes: 87 additions & 0 deletions internal/fs/local_modifications_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"io/ioutil"
"os"
"path"
"reflect"
"runtime"
"sort"
"strings"
Expand All @@ -33,8 +34,10 @@ import (
"unicode"
"unicode/utf8"

"github.com/googlecloudplatform/gcsfuse/v2/internal/gcsx"
"github.com/googlecloudplatform/gcsfuse/v2/internal/storage/gcs"
"github.com/googlecloudplatform/gcsfuse/v2/internal/storage/storageutil"
"github.com/googlecloudplatform/gcsfuse/v2/tools/integration_tests/util/operations"
"github.com/jacobsa/fuse/fusetesting"
. "github.com/jacobsa/oglematchers"
. "github.com/jacobsa/ogletest"
Expand Down Expand Up @@ -1523,6 +1526,90 @@ func (t *FileTest) WriteAtDoesntChangeOffset_AppendMode() {
ExpectEq(4, offset)
}

func validateObjectAttributes(extendedAttr1, extendedAttr2 *gcs.ExtendedObjectAttributes,
minObject1, minObject2 *gcs.MinObject) {
AssertNe(nil, extendedAttr1)
AssertNe(nil, extendedAttr2)
AssertNe(nil, minObject1)
AssertNe(nil, minObject2)
// Validate Min Object.
ExpectEq(minObject1.Name, minObject2.Name)
ExpectEq(0, minObject1.Size)
ExpectEq(FileContentsSize, minObject2.Size)
ExpectNe(minObject1.Generation, minObject2.Generation)
ExpectTrue(minObject1.Updated.Before(minObject2.Updated))
attr1MTime, _ := time.Parse(time.RFC3339Nano, minObject1.Metadata[gcsx.MtimeMetadataKey])
attr2MTime, _ := time.Parse(time.RFC3339Nano, minObject2.Metadata[gcsx.MtimeMetadataKey])
ExpectTrue(attr1MTime.Before(attr2MTime))
ExpectEq(minObject1.ContentEncoding, minObject2.ContentEncoding)

// Validate Extended Object Attributes.
ExpectEq(extendedAttr1.ContentType, extendedAttr2.ContentType)
ExpectEq(extendedAttr1.ContentLanguage, extendedAttr2.ContentLanguage)
ExpectEq(extendedAttr1.CacheControl, extendedAttr2.CacheControl)
ExpectEq(extendedAttr1.Owner, extendedAttr2.Owner)
ExpectNe(nil, extendedAttr1.CRC32C)
ExpectNe(nil, extendedAttr2.CRC32C)
ExpectEq(extendedAttr1.MediaLink, extendedAttr2.MediaLink)
ExpectEq(extendedAttr1.StorageClass, extendedAttr2.StorageClass)
ExpectTrue(reflect.DeepEqual(extendedAttr1.Deleted, time.Time{}))
ExpectTrue(reflect.DeepEqual(extendedAttr2.Deleted, time.Time{}))
ExpectEq(extendedAttr1.ComponentCount+1, extendedAttr2.ComponentCount)
ExpectEq(extendedAttr1.EventBasedHold, extendedAttr2.EventBasedHold)
ExpectEq(extendedAttr1.Acl, extendedAttr2.Acl)
ExpectEq(nil, extendedAttr1.Acl)
}

func createFile(filePath string) {
f, err := os.Create(filePath)
AssertEq(nil, err)
err = f.Close()
AssertEq(nil, err)
}

func (t *FileTest) AppendFileOperation_ShouldNotChangeObjectAttributes() {
// Create file.
fileName := "foo"
createFile(path.Join(mntDir, fileName))
// Fetch object attributes before file append.
minObject1, extendedAttr1, err := bucket.StatObject(ctx, &gcs.StatObjectRequest{Name: fileName, ForceFetchFromGcs: true, ReturnExtendedObjectAttributes: true})
AssertEq(nil, err)
time.Sleep(timeSlop + timeSlop/2)

// Append to the file.
err = operations.WriteFileInAppendMode(path.Join(mntDir, fileName), FileContents)
AssertEq(nil, err)

// Fetch object attributes after file append.
minObject2, extendedAttr2, err := bucket.StatObject(ctx, &gcs.StatObjectRequest{Name: fileName, ForceFetchFromGcs: true, ReturnExtendedObjectAttributes: true})
AssertEq(nil, err)
// Validate object attributes are as expected.
validateObjectAttributes(extendedAttr1, extendedAttr2, minObject1, minObject2)
}

func (t *FileTest) WriteAtFileOperation_ShouldNotChangeObjectAttributes() {
// Create file.
fileName := "foo"
createFile(path.Join(mntDir, fileName))
// Fetch object attributes before file append.
minObject1, extendedAttr1, err := bucket.StatObject(ctx, &gcs.StatObjectRequest{Name: fileName, ForceFetchFromGcs: true, ReturnExtendedObjectAttributes: true})
AssertEq(nil, err)
time.Sleep(timeSlop + timeSlop/2)

// Over-write the file.
fh, err := os.OpenFile(path.Join(mntDir, fileName), os.O_RDWR, operations.FilePermission_0600)
AssertEq(nil, err)
_, err = fh.WriteAt([]byte(FileContents), 0)
AssertEq(nil, err)
err = fh.Close()
AssertEq(nil, err)
minObject2, extendedAttr2, err := bucket.StatObject(ctx, &gcs.StatObjectRequest{Name: fileName, ForceFetchFromGcs: true, ReturnExtendedObjectAttributes: true})
AssertEq(nil, err)

// Validate object attributes are as expected.
validateObjectAttributes(extendedAttr1, extendedAttr2, minObject1, minObject2)
}

func (t *FileTest) ReadsPastEndOfFile() {
var err error
var n int
Expand Down
Loading