Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading go storage sdk version from 1.38.0 to 1.40.0 #1819

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Upgrading go storage sdk version from 1.38.0 to 1.40.0 #1819

merged 1 commit into from
Apr 1, 2024

Conversation

raj-prince
Copy link
Collaborator

@raj-prince raj-prince commented Apr 1, 2024 •
edited
Loading

Description

  • Upgrading go_sdk_version from 1.38.0 to 1.40.0
  • This also fixes the 429 retry issue - retry doesn't work for 429 error while writing through gRPC client.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@raj-prince raj-prince added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Apr 1, 2024
@raj-prince raj-prince changed the title Upgrading go storage sdk version Upgrading go storage sdk version from 1.38.0 to 1.40.0 Apr 1, 2024
@raj-prince raj-prince marked this pull request as ready for review April 1, 2024 05:31
@raj-prince raj-prince requested a review from a team as a code owner April 1, 2024 05:31
@raj-prince raj-prince requested a review from sethiay April 1, 2024 05:31
@raj-prince
Copy link
Collaborator Author

Presubmit perf result:
image

@raj-prince raj-prince merged commit 33ec397 into master Apr 1, 2024
8 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 23, 2024
Merged
@kislaykishore kislaykishore deleted the go_sdk_upgrade_1.40.0 branch November 28, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethiay sethiay sethiay approved these changes

Assignees
No one assigned
Labels
execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raj-prince @sethiay