Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling gRPC related integration test #1823

Merged
merged 11 commits into from
Apr 24, 2024
Merged

Enabling gRPC related integration test #1823

merged 11 commits into from
Apr 24, 2024

Conversation

raj-prince
Copy link
Collaborator

@raj-prince raj-prince commented Apr 1, 2024 •
edited
Loading

Description

  • Enabling e2e test for gRPC changes.
  • Added support of -short flag while running the integration test, this will skip few tests inside test package.
  • Enabling only important tests (operations) for gRPC as part presubmit test. But exhaustive test will be run as part of e2e test.

Currently time taken by pre-submit test - 34m.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@raj-prince raj-prince added the execute-integration-tests Run only integration tests label Apr 1, 2024
@raj-prince raj-prince marked this pull request as ready for review April 2, 2024 06:41
@raj-prince raj-prince requested review from ashmeenkaur and a team as code owners April 2, 2024 06:41
@raj-prince raj-prince requested a review from sethiay April 2, 2024 06:41
@raj-prince raj-prince assigned sethiay and unassigned sethiay Apr 2, 2024
@raj-prince raj-prince requested review from sethiay and removed request for sethiay April 2, 2024 06:41
@raj-prince raj-prince force-pushed the enable_grpc_integration_test branch from b5e7381 to a8102ca Compare April 5, 2024 07:41
Tulsishah
Tulsishah previously approved these changes Apr 16, 2024
View reviewed changes
ashmeenkaur
ashmeenkaur reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@ashmeenkaur ashmeenkaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, PTAL :)

sethiay
sethiay approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@sethiay sethiay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relying on Ashmeen's and Tulsi's review.

@raj-prince raj-prince merged commit 1fc90c9 into master Apr 24, 2024
8 checks passed
@Tulsishah Tulsishah mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashmeenkaur ashmeenkaur ashmeenkaur approved these changes

@sethiay sethiay sethiay approved these changes

@Tulsishah Tulsishah Awaiting requested review from Tulsishah Tulsishah is a code owner

Assignees
No one assigned
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raj-prince @sethiay @Tulsishah @ashmeenkaur