Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intro anonymous-access flag #1827

Merged
merged 39 commits into from
Apr 30, 2024
Merged

Intro anonymous-access flag #1827

merged 39 commits into from
Apr 30, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Apr 3, 2024 •
edited
Loading

Description

  • Introducing new flag auth-config: anonymous-access: true/false.
  • Authentication is by default on(auth-config: anonymous-access:false)
  • In case of disabling authentication, We have to externally pass anonymous-access: skip: true/false. flag in config file.
  • gRPC client
    • Logging incase of Cx pass --custom-endpoint with gRPC flow that GRPC path is not supported with authentication on custom endpoint.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual
    9fLHX9SSyyv3eTR
    3jh8ZHdAYkEpJiZ
  2. Unit tests - Added
  3. Integration tests - Automated

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label Apr 5, 2024
@Tulsishah Tulsishah force-pushed the intro_disable_auth_flag branch 2 times, most recently from e74054d to 826b3e7 Compare April 18, 2024 08:41
@Tulsishah Tulsishah changed the title Intro disable auth flag Intro skip auth flag Apr 24, 2024
@Tulsishah Tulsishah marked this pull request as ready for review April 25, 2024 09:07
@Tulsishah Tulsishah requested a review from a team as a code owner April 25, 2024 09:07
raj-prince
raj-prince reviewed Apr 25, 2024
View reviewed changes
main_test.go Outdated Show resolved Hide resolved
raj-prince
raj-prince reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. Please check.

@Tulsishah Tulsishah changed the title Intro skip auth flag Intro anonymous-access flag Apr 29, 2024
raj-prince
raj-prince reviewed Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of minor comments.

Can we also run performance test - since changes are around custom http client?

@Tulsishah Tulsishah added the execute-perf-test Execute performance test in PR label Apr 30, 2024
@Tulsishah
Copy link
Collaborator Author

LGTM, a couple of minor comments.

Can we also run performance test - since changes are around custom http client?
Bq6eJshZWHYpsNU

@Tulsishah Tulsishah removed the execute-perf-test Execute performance test in PR label Apr 30, 2024
@Tulsishah Tulsishah merged commit 7742c68 into master Apr 30, 2024
8 checks passed
@Tulsishah Tulsishah deleted the intro_disable_auth_flag branch July 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

Assignees
No one assigned
Labels
execute-integration-tests Run only integration tests tulsishah
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tulsishah @raj-prince