Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change authentication flow for TPC #1840

Merged
merged 11 commits into from
Apr 18, 2024
Merged

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Apr 10, 2024

Description

We have discussed this with the GO SDK team, and confirmed that their WithCredentialJSON function is doing oAuth2 authentication for GDU (Google domain universe) flow or else use self signed JWT access token flow .

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - Added
  3. Integration tests - Automated

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label Apr 10, 2024
@Tulsishah Tulsishah marked this pull request as ready for review April 10, 2024 11:52
@Tulsishah Tulsishah requested a review from a team as a code owner April 10, 2024 11:52
@Tulsishah Tulsishah changed the title Change authentication flow for tpc Change authentication flow for TPC Apr 12, 2024
internal/auth/auth.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comment, PTAL.

@Tulsishah
Copy link
Collaborator Author

Few minor comment, PTAL.

Fixed. PTAL

internal/auth/auth.go Outdated Show resolved Hide resolved
internal/auth/auth.go Outdated Show resolved Hide resolved
@Tulsishah Tulsishah merged commit 7e33d03 into master Apr 18, 2024
8 checks passed
@Tulsishah Tulsishah deleted the change_authentication_flow_for_tpc branch July 19, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants