-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR-1] Add flag and config to ignore interrupts #1863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmeenkaur
force-pushed
the
add_flag_to_ignore_interrupts
branch
from
April 24, 2024 09:53
81ee0df
to
2c3a6c0
Compare
ashmeenkaur
force-pushed
the
add_flag_to_ignore_interrupts
branch
from
April 25, 2024 10:56
2c3a6c0
to
50f023a
Compare
raj-prince
reviewed
Apr 25, 2024
raj-prince
reviewed
Apr 25, 2024
raj-prince
reviewed
Apr 25, 2024
raj-prince
reviewed
Apr 25, 2024
raj-prince
reviewed
Apr 25, 2024
raj-prince
reviewed
Apr 25, 2024
raj-prince
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few minor comments.
Also, please update the description with the default value of ignore-interrupts.
raj-prince
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
ignore-interrupts
flag andfile-system: ignore-interrupts
config. The priority is given to the cli flag if both are set. The default value of the flag and config is false.Link to the issue in case of a bug fix.
NA
Testing details