Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ignore interrupt integration tests #1925

Merged
merged 4 commits into from
May 16, 2024

Conversation

ashmeenkaur
Copy link
Collaborator

@ashmeenkaur ashmeenkaur commented May 16, 2024

Description

The tests were failing on CD pipeline with the following error:

git_clone_test.go:116: Git empty commit failed: : failed command '/bin/bash -c git commit --allow-empty -m " empty commit"': exit status 128, Author identity unknown
        
        *** Please tell me who you are.
        
        Run
        
          git config --global user.email "you@example.com"
          git config --global user.name "Your Name"
        
        to set your account's default identity.

Fixed by setting the user config before running the tests.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Manually ran on debian 11 and centos 7 VM to verify the fix.
    4Xm7BAfLESVRzHh
    78EwQPAwjcuxMkY

  2. Unit tests - NA

  3. Integration tests - Ran on KOKORO

@ashmeenkaur ashmeenkaur added the execute-integration-tests Run only integration tests label May 16, 2024
@ashmeenkaur ashmeenkaur force-pushed the fix_interrupt_integration_tests branch from 0e7d942 to 0177079 Compare May 16, 2024 09:02
@ashmeenkaur ashmeenkaur changed the title fix interrupt integration tests fix ignore interrupt integration tests May 16, 2024
@ashmeenkaur ashmeenkaur force-pushed the fix_interrupt_integration_tests branch from f46e004 to 432bbe6 Compare May 16, 2024 09:13
@ashmeenkaur ashmeenkaur force-pushed the fix_interrupt_integration_tests branch from 432bbe6 to cb41601 Compare May 16, 2024 09:16
@ashmeenkaur ashmeenkaur requested a review from sethiay May 16, 2024 09:29
@ashmeenkaur ashmeenkaur marked this pull request as ready for review May 16, 2024 09:31
@ashmeenkaur ashmeenkaur requested a review from a team as a code owner May 16, 2024 09:31
@ashmeenkaur ashmeenkaur merged commit f535453 into master May 16, 2024
8 checks passed
@ashmeenkaur ashmeenkaur deleted the fix_interrupt_integration_tests branch July 19, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants