-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling gRPC test temporarily #1929
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1929 +/- ##
=========================================
Coverage ? 61.52%
=========================================
Files ? 129
Lines ? 12298
Branches ? 0
=========================================
Hits ? 7566
Misses ? 4395
Partials ? 337
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you add short flag to tools/cd_scripts/e2e_test.sh as well?
Description
Currently, -short flag totally hijacked by gRPC.
Need to revert this PR once b/333307965 is fixed, created another bug to revert this PR b/341240872.
Link to the issue in case of a bug fix.
NA
Testing details