-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete folder api implementation #1954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tulsishah
force-pushed
the
implement_delete_api
branch
from
May 27, 2024 13:21
545dbd1
to
4a776e6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1954 +/- ##
==========================================
- Coverage 73.65% 73.32% -0.34%
==========================================
Files 97 97
Lines 10381 10450 +69
==========================================
+ Hits 7646 7662 +16
- Misses 2398 2447 +49
- Partials 337 341 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tulsishah
changed the title
delete folder api implementation
Delete folder api implementation
May 30, 2024
ankitaluthra1
requested changes
May 31, 2024
Tulsishah
force-pushed
the
implement_delete_api
branch
from
June 10, 2024 06:34
2a7ee14
to
c58d61b
Compare
Tulsishah
force-pushed
the
implement_delete_api
branch
from
June 12, 2024 05:54
fa11940
to
60d97b3
Compare
ankitaluthra1
approved these changes
Jun 13, 2024
charith87
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented the DeleteFolder API for HNS buckets. For HNS buckets, it will first attempt to call deleteObject. If this results in a "not found" error, it will be ignored, as the object may still exist as a folder within the HNS bucket. A second call will then be made from the control client to specifically delete the folder.
For FLAT bucket the existing flow will hit.
Link to the issue in case of a bug fix.
NA
Testing details