Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all config-params to params.yaml #1999

Merged
merged 15 commits into from
Jun 13, 2024
Merged

Add all config-params to params.yaml #1999

merged 15 commits into from
Jun 13, 2024

Conversation

kislaykishore
Copy link
Collaborator

Description

  • All all currently used params to params.yaml.
  • Generate int flags with type as int64 as opposed to platform-dependent int.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@kislaykishore kislaykishore requested a review from a team as a code owner June 11, 2024 06:17
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 256 lines in your changes missing coverage. Please review.

Project coverage is 72.36%. Comparing base (c28f219) to head (2a6545b).
Report is 14 commits behind head on master.

Files Patch % Lines
cfg/config.go 0.00% 256 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1999      +/-   ##
==========================================
- Coverage   73.54%   72.36%   -1.19%     
==========================================
  Files          97       97              
  Lines       10321    10819     +498     
==========================================
+ Hits         7591     7829     +238     
- Misses       2394     2648     +254     
- Partials      336      342       +6     
Flag Coverage Δ
unittests 72.36% <0.00%> (-1.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore changed the title Add all params to the params.yaml Add all config-params to the params.yaml Jun 11, 2024
@kislaykishore kislaykishore changed the title Add all config-params to the params.yaml Add all config-params to params.yaml Jun 11, 2024
Copy link
Collaborator

@ashmeenkaur ashmeenkaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not taken a look at generated file

tools/config-gen/params.yaml Outdated Show resolved Hide resolved
tools/config-gen/params.yaml Outdated Show resolved Hide resolved
tools/config-gen/params.yaml Show resolved Hide resolved
tools/config-gen/params.yaml Show resolved Hide resolved
tools/config-gen/params.yaml Show resolved Hide resolved
tools/config-gen/params.yaml Outdated Show resolved Hide resolved
tools/config-gen/params.yaml Show resolved Hide resolved
tools/config-gen/params.yaml Show resolved Hide resolved
tools/config-gen/params.yaml Outdated Show resolved Hide resolved
tools/config-gen/params.yaml Outdated Show resolved Hide resolved
cfg/config.go Outdated Show resolved Hide resolved
Co-authored-by: Ashmeen Kaur <57195160+ashmeenkaur@users.noreply.github.com>
@kislaykishore kislaykishore merged commit 19deef4 into master Jun 13, 2024
12 checks passed
@kislaykishore kislaykishore deleted the all-params2 branch June 13, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants