Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all except cache tests concurrently #2022

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Run all except cache tests concurrently #2022

merged 3 commits into from
Jun 17, 2024

Conversation

kislaykishore
Copy link
Collaborator

@kislaykishore kislaykishore commented Jun 17, 2024

Description

  • Cache-tests cannot be run concurrently. So, except for cache-tests run other tests concurrently.
  • Hardcoding the port in fakestorage leads to bind conflicts if another fakestorage instance is running on the same port. This happens when the tests are run concurrently. Remove the hardcoding to let fakestorage find the port by itself and avoid the port conflict.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@kislaykishore kislaykishore requested a review from a team as a code owner June 17, 2024 02:25
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.26%. Comparing base (70b6407) to head (c3435b8).
Report is 1 commits behind head on master.

Files Patch % Lines
internal/storage/fake_storage_util.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2022      +/-   ##
==========================================
- Coverage   71.56%   71.26%   -0.30%     
==========================================
  Files          97       97              
  Lines       10705    10705              
==========================================
- Hits         7661     7629      -32     
- Misses       2703     2732      +29     
- Partials      341      344       +3     
Flag Coverage Δ
unittests 71.26% <33.33%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ashmeenkaur ashmeenkaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM logically. @raj-prince can you check why running cache tests in parallel even with dynamic port runs into errors/conflicts and if we can do something to fix it?

@kislaykishore kislaykishore merged commit 21e4ae4 into master Jun 17, 2024
12 checks passed
@kislaykishore kislaykishore deleted the test-parallel branch June 17, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants