Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Wait for Download false for all read scenarios when parallel downloads is true #2027

Merged
merged 11 commits into from
Jun 18, 2024

Conversation

ankitaluthra1
Copy link
Collaborator

Description

Make Wait for Download false for all read scenarios when parallel downloads is true

Link to the issue in case of a bug fix.

b/345645002

Testing details

  1. Manual - NA
  2. Unit tests - Done
  3. Integration tests - NA

@ankitaluthra1 ankitaluthra1 requested a review from a team as a code owner June 18, 2024 04:23
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.54%. Comparing base (1e42721) to head (18d7e6e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2027      +/-   ##
==========================================
+ Coverage   71.37%   71.54%   +0.17%     
==========================================
  Files          97       98       +1     
  Lines       10709    10759      +50     
==========================================
+ Hits         7644     7698      +54     
+ Misses       2722     2718       -4     
  Partials      343      343              
Flag Coverage Δ
unittests 71.54% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/cache/file/cache_handle_test.go Outdated Show resolved Hide resolved
internal/cache/file/cache_handle_test.go Outdated Show resolved Hide resolved
internal/cache/file/cache_handle_test.go Outdated Show resolved Hide resolved
internal/cache/file/cache_handle_test.go Show resolved Hide resolved
internal/cache/file/cache_handle_test.go Outdated Show resolved Hide resolved
@ankitaluthra1 ankitaluthra1 added the execute-integration-tests Run only integration tests label Jun 18, 2024
@ankitaluthra1 ankitaluthra1 merged commit 6f3acc0 into master Jun 18, 2024
13 checks passed
@ankitaluthra1 ankitaluthra1 deleted the wait-update-in-seq-read branch June 18, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants